Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/datadog 9869: Validate credentials when initialising client. #10567

Merged
merged 4 commits into from
Dec 8, 2016
Merged

provider/datadog 9869: Validate credentials when initialising client. #10567

merged 4 commits into from
Dec 8, 2016

Conversation

ojongerius
Copy link
Contributor

@ojongerius ojongerius commented Dec 7, 2016 •
edited
Loading

Validate credentials when initialising client. Addresses #9869

@ojongerius
Merge remote-tracking branch 'upstream/master' into 9869_validate_cre…
62513c4 
…dentials

* upstream/master: (79 commits)
  update CHANGELOG
  Update panicwrap to pass through all interrupt signals
  Gracefully stops on SIGTERM
  website: update website for conditionals
  vendor: update HIL with conditionals
  Keep a consistent provider order.
  Update CHANGELOG.md
  provider/aws: Forces the api gateway domain name certificates to recreate the resource (hashicorp#10588)
  Update CHANGELOG.md
  provider/aws: FIxed the api_gw_domain_name replace operation (hashicorp#10179)
  Fixed note formatting
  Explicitly say `count` is not supported by modules (hashicorp#10553)
  docs/aws: Fix the discrepencies of the emr_cluster documentation (hashicorp#10578)
  Update CHANGELOG.md
  Service role is not updated on AWS for a CodeDeploy deployment group (hashicorp#9866)
  Update CHANGELOG.md
  provider/datadog hashicorp#9375: Refactor tags to a list instead of a map. (hashicorp#10570)
  Update the Vagrantfile to resolve package update/installation issue. (hashicorp#9783)
  docs/aws: Add iam_server_certificate data source to nav bar (hashicorp#10576)
  Update CHANGELOG.md
  ...
@ojongerius
provider/datadog Pull in new version of go-datadog-api.
a864f51
@ojongerius ojongerius force-pushed the 9869_validate_credentials branch from ef71418 to a864f51 Compare December 8, 2016 04:13
@ojongerius ojongerius force-pushed the 9869_validate_credentials branch from d72132f to 0b4d3ad Compare December 8, 2016 04:29
@ojongerius
Copy link
Contributor Author

ojongerius commented Dec 8, 2016 •
edited
Loading

Upstream changes merged and pulled in.

Acceptance tests pass:

github.com/hashicorp/terraform  9869_validate_credentials ✔                                                                                                                                                                                                                                                                                                                                                             6m  ⍉
▶ make testacc TEST=./builtin/providers/datadog                                                      
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/08 15:29:31 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/datadog -v  -timeout 120m
=== RUN   TestDatadogMonitor_import
--- PASS: TestDatadogMonitor_import (91.87s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (90.65s)
=== RUN   TestAccDatadogMonitor_BasicNoTreshold
--- PASS: TestAccDatadogMonitor_BasicNoTreshold (68.27s)
=== RUN   TestAccDatadogMonitor_Updated
--- PASS: TestAccDatadogMonitor_Updated (71.59s)
=== RUN   TestAccDatadogMonitor_TrimWhitespace
--- PASS: TestAccDatadogMonitor_TrimWhitespace (72.98s)
=== RUN   TestAccDatadogMonitor_Basic_float_int
--- PASS: TestAccDatadogMonitor_Basic_float_int (85.93s)
=== RUN   TestAccDatadogTimeboard_update
--- PASS: TestAccDatadogTimeboard_update (84.04s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/datadog        565.343s

github.com/hashicorp/terraform  9869_validate_credentials ✔

@stack72
Copy link
Contributor

stack72 commented Dec 8, 2016

Nice Addition! Love validation before trying to make a client request

@stack72 stack72 merged commit 10d68d9 into hashicorp:master Dec 8, 2016
@stack72 stack72 mentioned this pull request Dec 8, 2016
Closed
@ojongerius ojongerius deleted the 9869_validate_credentials branch December 8, 2016 10:28
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/datadog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojongerius @stack72