provider/aws: FIxed the api_gw_domain_name replace operation

[Ninir]

This fixes partially #8789.

When you try to update the certificate_name, which is allowed per https://docs.aws.amazon.com/apigateway/api-reference/link-relation/domainname-update/, you get the following response:

aws_api_gateway_domain_name.hsts: BadRequestException: Invalid patch path '/certificate_name' specified for op 'replace'. Must be one of: [/certificateName]

This updates the replace paths in order to remove this error. This does not try to fix the issue about updating the certificate, which should be about forcing a new resource.

Another PR will follow which will be about forcing new resources for certificate changes.

[stack72]

Hi @Ninir

Doesn't look like the tests work as expected here -

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDomainName_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/07 13:43:29 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDomainName_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayDomainName_basic
--- FAIL: TestAccAWSAPIGatewayDomainName_basic (0.00s)
	testing.go:265: Step 0 error: Error loading configuration: Error parsing /var/folders/gd/yv86v7pd1cd5dpzjrw8702k00000gn/T/tf-test603301176/main.tf: At 15:59: expected '/' for comment
FAIL
exit status 1
FAIL	github.com/hashicorp/terraform/builtin/providers/aws	0.025s
make: *** [testacc] Error 1

Could you take a look?

Thanks

Paul

[Ninir]

Hi @stack72

It is the same on the master branch apparently, will investigate and fix it in this one too :)
Thanks for spotting this!

[Ninir]

Found the issue, it was about the way to set the certificate data, which was wrong since the beginning unfortunately :/. ('Think I forgot to ran tests when throwing the PR... should be all good now :))

Here are the acceptance tests:

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDomainName_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/07 17:40:00 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDomainName_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayDomainName_basic
--- PASS: TestAccAWSAPIGatewayDomainName_basic (70.32s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	70.349s

[Ninir]

This is done on purpose to avoid a diff issue. The other solution would be to update line 43 for instance, adding:

...
resource.TestCheckResourceAttr("aws_api_gateway_domain_name.test", "certificate_body", fmt.Sprintf("%v\n", testAccAWSAPIGatewayCertBody),
...

[stack72]

Thanks for the work herre @Ninir :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDomainName_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/07 21:27:36 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDomainName_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayDomainName_basic
--- PASS: TestAccAWSAPIGatewayDomainName_basic (54.79s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	54.824s

[Ninir]

Thank you for the review @stack72 :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.