provider/datadog #9375: Refactor tags to a list instead of a map.

[ojongerius]

Tags are allowed to be but not restricted to, key value pairs (ie: foo:bar)
but are esssentially strings.

This changes allows using, and mixing of tags with form "foo" and "foo:bar". It also allows using duplicate keys like "foo:bar" and "foo:baz".

Addresses #9375

[stack72]

Hey @ojongerius

Thanks for the work here - looks like the tests are broken I'm afraid

% make testacc TEST=./builtin/providers/datadog
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/07 11:24:29 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/datadog -v  -timeout 120m
=== RUN   TestDatadogMonitor_import
--- FAIL: TestDatadogMonitor_import (0.00s)
	testing.go:265: Step 0 error: Configuration is invalid.

		Warnings: []string(nil)

		Errors: []string{"datadog_monitor.foo: tags.0 must be a single value, not a map"}
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (83.46s)
=== RUN   TestAccDatadogMonitor_BasicNoTreshold
--- FAIL: TestAccDatadogMonitor_BasicNoTreshold (0.00s)
	testing.go:265: Step 0 error: Configuration is invalid.

		Warnings: []string(nil)

		Errors: []string{"datadog_monitor.foo: tags.0 must be a single value, not a map"}

Paul

[ojongerius]

That's what you get for only running specific tests. Sorry about that. Updating the test config in testAccCheckDatadogMonitorConfigImported makes acceptance pass for me:

▶ make testacc TEST=./builtin/providers/datadog
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/07 21:50:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/datadog -v  -timeout 120m
=== RUN   TestDatadogMonitor_import
--- PASS: TestDatadogMonitor_import (92.21s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (87.26s)
=== RUN   TestAccDatadogMonitor_Updated
--- PASS: TestAccDatadogMonitor_Updated (69.21s)
=== RUN   TestAccDatadogMonitor_TrimWhitespace
--- PASS: TestAccDatadogMonitor_TrimWhitespace (69.36s)
=== RUN   TestAccDatadogMonitor_Basic_float_int
--- PASS: TestAccDatadogMonitor_Basic_float_int (74.80s)
=== RUN   TestAccDatadogTimeboard_update
--- PASS: TestAccDatadogTimeboard_update (80.98s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/datadog	473.846s

github.com/hashicorp/terraform  9375_fix_tags ✔

[stack72]

You rock sir :) This LGTM!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.