Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecommit repository always created in us-east-1 #11175

Closed
yesteph opened this issue Jan 12, 2017 · 3 comments · Fixed by #11177
Closed

Codecommit repository always created in us-east-1 #11175

yesteph opened this issue Jan 12, 2017 · 3 comments · Fixed by #11177
Labels
bug provider/aws

Comments

@yesteph
Copy link

yesteph commented Jan 12, 2017

Hi there,

Terraform Version

0.8.4

Affected Resource(s)

  • aws_codecommit_repository

Terraform Configuration Files

provider "aws" {
  region = "eu-west-1"
}
resource "aws_codecommit_repository" "backend_java" {
  repository_name = "backend-java"
  description = "Barcode generator backend"
}

Expected Behavior

backend-java repository created in eu-west-1 region

Actual Behavior

backend-java repository created in us-east-1 region (default)

Steps to Reproduce

  1. terraform apply
stack72 added a commit that referenced this issue Jan 12, 2017
@stack72
provider/aws: Allow creating aws_codecommit repository outside of
6035992 
us-east-1

Fixes #11175

Because of a previous limitation that codecommit only ran in us-east-1,
we hard coded the session under which it should run. This has caused the
repository to be spun up in the wrong region regardless of what region
was passed to the provider

```
make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCodeCommitRepository_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/12 16:09:52 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCodeCommitRepository_ -timeout 120m
=== RUN   TestAccAWSCodeCommitRepository_basic
--- PASS: TestAccAWSCodeCommitRepository_basic (23.28s)
=== RUN   TestAccAWSCodeCommitRepository_withChanges
--- PASS: TestAccAWSCodeCommitRepository_withChanges (33.71s)
=== RUN   TestAccAWSCodeCommitRepository_create_default_branch
--- PASS: TestAccAWSCodeCommitRepository_create_default_branch (22.70s)
=== RUN   TestAccAWSCodeCommitRepository_create_and_update_default_branch
--- PASS: TestAccAWSCodeCommitRepository_create_and_update_default_branch (32.72s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	112.437s
```
@stack72 stack72 mentioned this issue Jan 12, 2017
Merged
@stack72
Copy link
Contributor

stack72 commented Jan 12, 2017

Hi @yesteph

Thanks for finding this bug - I just opened a PR that will fix it :)

It will be part of the next Terraform release

Thanks

Paul

@stack72 stack72 closed this as completed Jan 12, 2017
stack72 added a commit that referenced this issue Jan 12, 2017
@stack72
provider/aws: Allow creating aws_codecommit repository outside of (#1…
73e9509 
…1177)

us-east-1

Fixes #11175

Because of a previous limitation that codecommit only ran in us-east-1,
we hard coded the session under which it should run. This has caused the
repository to be spun up in the wrong region regardless of what region
was passed to the provider

```
make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCodeCommitRepository_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/12 16:09:52 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCodeCommitRepository_ -timeout 120m
=== RUN   TestAccAWSCodeCommitRepository_basic
--- PASS: TestAccAWSCodeCommitRepository_basic (23.28s)
=== RUN   TestAccAWSCodeCommitRepository_withChanges
--- PASS: TestAccAWSCodeCommitRepository_withChanges (33.71s)
=== RUN   TestAccAWSCodeCommitRepository_create_default_branch
--- PASS: TestAccAWSCodeCommitRepository_create_default_branch (22.70s)
=== RUN   TestAccAWSCodeCommitRepository_create_and_update_default_branch
--- PASS: TestAccAWSCodeCommitRepository_create_and_update_default_branch (32.72s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	112.437s
```
@yesteph
Copy link
Author

yesteph commented Jan 13, 2017

Thank you Paul.

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

provider/aws: Allow creating aws_codecommit repository outside of us-east-1 hashicorp/terraform
2 participants
@stack72 @yesteph