Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Only send iops when creating io1 devices. Fix docs #12392

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Mar 2, 2017

I think #11619 revealed a "bug" in our tests where iops were being specified in a gp2 volume. Because the root_block_device hash was always zero (it couldn't be changed), we failed to detect this.

Fixes TestAccAWSInstance_GP2IopsDevice test error:

------- Stdout: -------
=== RUN   TestAccAWSInstance_GP2IopsDevice
--- FAIL: TestAccAWSInstance_GP2IopsDevice (168.38s)
    testing.go:265: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: aws_instance.foo
          associate_public_ip_address:               "true" => "<computed>"
          availability_zone:                         "us-west-2c" => "<computed>"
          ebs_block_device.#:                        "0" => "<computed>"
          ephemeral_block_device.#:                  "0" => "<computed>""
          root_block_device.#:                       "1" => "1"
          root_block_device.0.delete_on_termination: "true" => "true"
          root_block_device.0.iops:                  "100" => "330" (forces new resource)

Test runs:

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_GP2IopsDevice -timeout 120m
=== RUN   TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_GP2IopsDevice (59.02s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	59.051s
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_blockDevices -timeout 120m
=== RUN   TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_blockDevices (85.59s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	85.613s

@stack72 stack72 merged commit d2f728e into master Mar 7, 2017
@stack72 stack72 deleted the b-aws-iops-for-io1-sake branch March 7, 2017 12:44
catsby added a commit that referenced this pull request Mar 7, 2017
* 'master' of github.com:hashicorp/terraform:
  provider/datadog: Update to datadog_monitor still used d.GetOk (#12497)
  Check instance is running before trying to attach (#12459)
  Fix aws_dms_replication_task diff for json with whitespace. (#12380)
  add "name" to exported attributes (#12483)
  provider/aws: Adding an acceptance test to for ForceNew on ecs_task_definition volumes
  provider/aws: (#10587) Changing volumes in ECS task definition should force new revision.
  provider/aws: Change aws_spot_fleet_request tests to use the correct hash values in test cases
  Small doc updates (#12165)
  Improve description of consul_catalog_entry (#12162)
  provider/aws: Only send iops when creating io1 devices. Fix docs (#12392)
  provider/google: initial commit for node pool resource (#11802)
  Fix spurious user_data diffs
  Properly handle 'vpc_security_group_ids', drop phantom 'security_groups'
  Default 'ebs_optimized' and 'monitoring' to false
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants