Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of consul_catalog_entry #12162

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Improve description of consul_catalog_entry #12162

merged 1 commit into from
Mar 7, 2017

Conversation

blalor
Copy link
Contributor

@blalor blalor commented Feb 22, 2017

The other resources for this provider are similarly misleading (they read like data sources).

Also adding undocumented properties of the resource.

The other resources for this provider are similarly misleading (they read like data sources).

Also adding undocumented properties of the resource.
@stack72
Copy link
Contributor

stack72 commented Mar 7, 2017

LGTM - thanks for the changes here!

@stack72 stack72 merged commit 0b86809 into hashicorp:master Mar 7, 2017
stack72 pushed a commit that referenced this pull request Mar 7, 2017
The other resources for this provider are similarly misleading (they read like data sources).

Also adding undocumented properties of the resource.
stack72 pushed a commit that referenced this pull request Mar 7, 2017
The other resources for this provider are similarly misleading (they read like data sources).

Also adding undocumented properties of the resource.
catsby added a commit that referenced this pull request Mar 7, 2017
* 'master' of github.com:hashicorp/terraform:
  provider/datadog: Update to datadog_monitor still used d.GetOk (#12497)
  Check instance is running before trying to attach (#12459)
  Fix aws_dms_replication_task diff for json with whitespace. (#12380)
  add "name" to exported attributes (#12483)
  provider/aws: Adding an acceptance test to for ForceNew on ecs_task_definition volumes
  provider/aws: (#10587) Changing volumes in ECS task definition should force new revision.
  provider/aws: Change aws_spot_fleet_request tests to use the correct hash values in test cases
  Small doc updates (#12165)
  Improve description of consul_catalog_entry (#12162)
  provider/aws: Only send iops when creating io1 devices. Fix docs (#12392)
  provider/google: initial commit for node pool resource (#11802)
  Fix spurious user_data diffs
  Properly handle 'vpc_security_group_ids', drop phantom 'security_groups'
  Default 'ebs_optimized' and 'monitoring' to false
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
The other resources for this provider are similarly misleading (they read like data sources).

Also adding undocumented properties of the resource.
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants