Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure VMSS documentation corrections #14906

Closed
gaborho opened this issue May 29, 2017 · 2 comments
Closed

Azure VMSS documentation corrections #14906

gaborho opened this issue May 29, 2017 · 2 comments

Comments

@gaborho
Copy link

gaborho commented May 29, 2017

Terraform Version

Terraform v0.9.6

Affected Resource(s)

  • azurerm_virtual_machine_scale_set

Terraform Configuration Files

storage_profile_os_disk {
    name              = "myosdisk"
    caching           = "ReadWrite"
    create_option     = "FromImage"
    managed_disk_type = "Standard_LRS"
  }

Expected Behavior

In case managed disks are used in Azure VMSS resource, name in storage_profile_os_disk must be set to blank. The example for managed disks in documentation should reflect this. Name should be blank in example.

Actual Behavior

With above example, Terraform drops following error:

* azurerm_virtual_machine_scale_set.playout-vmss: [ERROR] Conflict between `name` and `managed_disk_type` on `storage_profile_os_disk` (please set name to blank)

Additionally, there is a bug in documentation:
in lun section, there is extra Premium_LRS. which I think should belong to managed_disk_type section.

ebrucucen added a commit to ebrucucen/terraform that referenced this issue May 29, 2017
ebrucucen added a commit to ebrucucen/terraform that referenced this issue May 29, 2017
@tombuildsstuff
Copy link
Contributor

Hi @ATLD

Thanks for reporting these issues :)

PR #14915 has been merged which solves the documentation bugs raised here - so I'm going to close this issue. I've also opened issue #14932 to make the name field Optional, rather than Required - so it doesn't need to be set to an empty string for a managed disk.

Thanks! :)

justaugustus pushed a commit to justaugustus/tectonic-installer that referenced this issue Aug 8, 2017
`storage_profile_os_disk.name` must be set to "" when using managed disks.
See:
* hashicorp/terraform#14906
* hashicorp/terraform#14932
justaugustus pushed a commit to justaugustus/tectonic-installer that referenced this issue Aug 10, 2017
`storage_profile_os_disk.name` must be set to "" when using managed disks.
See:
* hashicorp/terraform#14906
* hashicorp/terraform#14932
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants