Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15354: Consul backend security options #15405

Conversation

loicalbertin
Copy link
Contributor

As per GH-15354 this pull-request allow to specify ca_file cert_file and key_file in order to interact with a secured Consul backend.

Tested with consul 0.8.4

… order to interact with a secured Consul backend
@loicalbertin
Copy link
Contributor Author

loicalbertin commented Jun 27, 2017

Note: this pull-request doesn't include proper unit tests because it would require to update the Consul dependency to v0.8+ in order to run a secured consul test server and I don't know your policy about those kind of upgrades.

@loicalbertin
Copy link
Contributor Author

Hi @apparentlymart,

Could you please review this pull-request please or ping someone that could do it.
Changes are very limited and it is IMHO an important security improvement.

Thanks & have a nice day!

@apparentlymart
Copy link
Contributor

Hi @loicalbertin! Thanks for working on this and sorry it got delayed by the 0.10.0 release work.

This looks great to me!

@apparentlymart apparentlymart merged commit 21b287e into hashicorp:master Aug 23, 2017
@loicalbertin
Copy link
Contributor Author

Hi @apparentlymart
No problem for the delay. I'm glad to see this merged and proud to add a very modest contribution to this great project! 😄
Thanks!

@loicalbertin loicalbertin deleted the GH-15354_ConsulBackendSecurityOptions branch August 26, 2017 17:42
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants