Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in consul backend #15976

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Fix crash in consul backend #15976

merged 1 commit into from
Sep 1, 2017

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Aug 31, 2017

A TLS config was being assigned to a Transport in a nil http.Client. The
Transport is built in the consul config by default, but the http.Client
is not built until later in NewClient.

No new tests, because the existing tests were sufficient to catch this.
This was introduced in #15405, but there were no ACC tests run.

Fixes #15972

A TLS config was being assigned to a Transport in a nil http.Client. The
Transport is built in the consul config by default, but the http.Client
is not built until later in NewClient.
@jbardin
Copy link
Member Author

jbardin commented Aug 31, 2017

=== RUN   TestBackend_impl
--- PASS: TestBackend_impl (0.00s)
=== RUN   TestBackend
--- PASS: TestBackend (4.17s)
	backend_test.go:55: TestBackend: testing state locking for *consul.Backend
=== RUN   TestBackend_lockDisabled
--- PASS: TestBackend_lockDisabled (3.16s)
	backend_test.go:78: TestBackend: testing state locking for *consul.Backend
	backend_test.go:78: TestBackend: *consul.Backend: empty string returned for lock, assuming disabled
=== RUN   TestBackend_gzip
--- PASS: TestBackend_gzip (2.55s)
=== RUN   TestRemoteClient_impl
--- PASS: TestRemoteClient_impl (0.00s)
=== RUN   TestRemoteClient
--- PASS: TestRemoteClient (2.48s)
=== RUN   TestRemoteClient_gzipUpgrade
--- PASS: TestRemoteClient_gzipUpgrade (2.15s)
=== RUN   TestConsul_stateLock
--- PASS: TestConsul_stateLock (3.74s)
=== RUN   TestConsul_destroyLock
--- PASS: TestConsul_destroyLock (1.88s)
=== RUN   TestConsul_lostLock
--- PASS: TestConsul_lostLock (2.42s)
PASS

@jbardin jbardin merged commit 6bd9e3f into master Sep 1, 2017
@jbardin jbardin deleted the jbardin/GH-15972 branch September 7, 2017 15:10
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on 0.10.3 when init with consul
2 participants