Update go-autorest to v9.10.0

[gsacavdm]

Update go-autorest to v9.10.0 to fix #18875 since go-autorest v9.7.0 has the required fix necessary to address the Azure AD auth endpoint update for Azure US Government. See announcement. While we could limit the update to v.9.7.0, might as well go to the highest non-major update for that version.

As indicated in the issue, even though this upgrades from 8.3 to 9.10, this isn't really a major update.

As per which references the go-autorest's changelog notes on v9.0.0:

IMPORTANT: This release was initially labeled incorrectly as v8.4.0. From the time it was released, it should have been marked v9.0.0 because it contains breaking changes to the MSI packages. We apologize for any inconvenience this causes.

Since upgrading from v8.3.0 to v.8.4.0 isn't a major update and based on the note above, upgrading from v8.4.0/v9.0.0 to v9.7.0 isn't upgrading across major releases either, this should be a low risk upgrade. Also, no breaking changes are indicated in the release that occurred between these versions.

[tombuildsstuff]

hey @gsacavdm

Thanks for this PR - taking a look through could we update the vendored code to use the tag (v9.10.0) rather than just pinning to a given commit - this'd ensure the same version of AutoRest is used across the vendored code.

Thanks!

[gsacavdm]

Fixed @tombuildsstuff :)

[gsacavdm]

Ping @tombuildsstuff

[tombuildsstuff]

@gsacavdm I've pushed a commit to update the vendoring to use v9.10.0 (rather than v11.x) - hope you don't mind. Going to ask someone else internally to review this since I've pushed those changes.

[gsacavdm]

Do you mean 9.10 or 9.1? I'm assuming 9.10 which is ok given that the required change is on v9.7, so anything greater than that is ok. Do you need anything from me to make this happen?

[gsacavdm]

Hey @tombuildsstuff , any updates on getting this merged?

[paultyng]

We are planning to get this in for the next TF patch release, just need to finish up some testing I believe.

[tombuildsstuff]

@gsacavdm as @paultyng has mentioned this'll go out as a part of the next patch release - we just need to do some edge-case testing to confirm there's nothing else broken here (which is on my list for this week) - sorry for the delay here!

new code

[gsacavdm]

Hurray! Thanks guys!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.