Update vendor of Azure/azure-sdk-for-go to v21.1.0 #18968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/Azure/azure-sdk-for-go packages @ v21.1.0 github.com/Azure/go-autorest @ v10.15.4, per azure-sdk-for-go Gopkg.toml Newly introduced github.com/marstr/guid @ v1.1.0, per azure-sdk-for-go Gopkg.toml Switch old ARM APIs to what appears to have been the newest API Version at the time Fix up the interfaces in tests.
|
Non-acceptance tests pass, not that you should take my word for it: |
|
The goal here is to give me a place to maybe implement #16763 (or maybe less SAS then the RBAC stuff in preview, https://aka.ms/oauthforstorage ) |
|
First attempt at running acceptance tests went |
|
Ran the acceptance tests;
this is an accurate reflection of the product when I got here, see also: #17046
The rest passed will look into TestPutMaintainsMetaData right now and maybe try to get that lease Id in there |
|
Got a pass on oh ... I see thats just a timeout for the whole run... https://stackoverflow.com/questions/27778280/test-killed-with-quit-ran-too-long/31336818 (a complete acceptance run takes 11m 3s 😢 against Go's 10m default timeout ) |
|
hey @donaldguy Thanks for this PR - apologies for the delayed review of this PR! We've recently been taking a look at how we can iterate on the AzureRM Backend to ensure it's consistent with the AzureRM Provider (and in the near future, the Azure Stack Provider). As a result of this we've split the authentication logic used by the AzureRM Provider out into it's own library which has since been incorporated in the AzureRM Repository and the Azure Stack repository - and PR #19414 integrates this library into the AzureRM Backend. As a result of this we've needed to ensure the version of the Azure SDK for Go used (and thus go-autorest) is consistent across all 3 codebases - as such I've opened #19414 which both includes/switches over to using this library and updates the SDK to v21.3.0 to match the other Providers. As such - whilst I'd like to thank you for this contribution I'm going to close this PR in favour of #19414 which supersedes this. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/Azure/azure-sdk-for-go packages @ v21.1.0
github.com/Azure/go-autorest @ v10.15.4, per azure-sdk-for-go Gopkg.toml
Newly introduced github.com/marstr/guid @ v1.1.0, per azure-sdk-for-go Gopkg.toml
Switch old ARM APIs to what appears to have been the newest API Version at the time
Fix up the interfaces in tests.