Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws crash when authenticating via instance profile on 0.6.2 #2955

Closed
bosmanx opened this issue Aug 6, 2015 · 12 comments
Closed

provider/aws crash when authenticating via instance profile on 0.6.2 #2955

bosmanx opened this issue Aug 6, 2015 · 12 comments

Comments

@bosmanx
Copy link

bosmanx commented Aug 6, 2015

Hi,

Looks like problem is with my tfstate - http://pastebin.com/BTaXQMxC

@phinze
Copy link
Contributor

phinze commented Aug 6, 2015

Sorry for the trouble! Let's see if we can't get this figured out.

Are you authenticating to AWS via access_key / secret_key or via another method?

@bosmanx
Copy link
Author

bosmanx commented Aug 6, 2015

I'm authenticating via instance profile. So I'm screwed anyway, as both #1595 and #2730 break instance profiles as both use iamconn.GetUser(nil):

* ValidationError: Must specify userName when calling with non-User credentials
        status code: 400, request id: [dabf17c6-3c8d-11e5-b79c-a50fb504c59a]

@phinze
Copy link
Contributor

phinze commented Aug 6, 2015

The reason I ask is it looks like a GetUser api call to test the provider config is where it failed:

2015/08/06 21:00:15 [ERROR] root: eval: *terraform.EvalConfigProvider, err: 1 error(s) occurred:

* ValidationError: Must specify userName when calling with non-User credentials
        status code: 400, request id: [22bdfc24-3c7e-11e5-a422-e51fd6279686]

@phinze
Copy link
Contributor

phinze commented Aug 6, 2015

@bosmanx sorry about this! we'll get it fixed up and cut another release as soon as we can.

@phinze
Copy link
Contributor

phinze commented Aug 6, 2015

Related: #2828

@phinze phinze changed the title provider/aws crashing on 0.6.2 provider/aws crash when authenticating via instance profile on 0.6.2 Aug 6, 2015
@catsby
Copy link
Contributor

catsby commented Aug 7, 2015

Hey @bosmanx , terribly sorry for the trouble here. I sent a patch in #2959 to address this, and right now I'm trying to duplicate the setup you described to confirm things work as expected. If you have the chance and ability to build Terraform from that branch, it would be awesome to help me confirm this is fixed. If not, I should know with some confidence soon.

Again, I sincerely apologize for this. We're working on patching and then cutting a new release today.

phinze added a commit that referenced this issue Aug 7, 2015
phinze added a commit that referenced this issue Aug 7, 2015
We weren't marking skipped nodes as failing, so any
grandchild-and-deeper dependencies would still evaluate.

For example:

    A -> B -> C -> D

If B failed, C would be skipped, but D would still be evaluated.

This fixes the behavior so C, D, and any further descendents will all be
skipped when B fails.

Addresses crashing aspect of #2955 and likely a lot of other confusing
failure modes.
phinze added a commit that referenced this issue Aug 7, 2015
We weren't marking skipped nodes as failing, so any
grandchild-and-deeper dependencies would still evaluate.

For example:

    A -> B -> C -> D

If B failed, C would be skipped, but D would still be evaluated.

This fixes the behavior so C, D, and any further descendents will all be
skipped when B fails.

Addresses crashing aspect of #2955 and likely a lot of other confusing
failure modes.
@jszwedko
Copy link
Contributor

jszwedko commented Aug 7, 2015

@catsby verified that this works for me, thanks for putting together this PR so quickly. Do you think it would be possible to release a patched version after this is merged? I'd really like to take advantage of some of the changes in 0.6.2, but this is blocking our ability to upgrade.

@catsby
Copy link
Contributor

catsby commented Aug 7, 2015

@jszwedko we're waiting on one more hot fix but yes, a new release should go out ASAP with this

@jszwedko
Copy link
Contributor

jszwedko commented Aug 7, 2015

Awesome, thank you @catsby !

@jszwedko
Copy link
Contributor

jszwedko commented Aug 7, 2015

Also, apologies for not responding to #2828 before 0.6.2 was cut.

@catsby
Copy link
Contributor

catsby commented Aug 7, 2015

#2959 and #2963 have been merged and will go out in the next release (targeting this coming Monday, August 10th ), so I'm going to close this now. Thanks for writing in! Sorry for the trouble

@catsby catsby closed this as completed Aug 7, 2015
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants