-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws crash when authenticating via instance profile on 0.6.2 #2955
Comments
Sorry for the trouble! Let's see if we can't get this figured out. Are you authenticating to AWS via access_key / secret_key or via another method? |
The reason I ask is it looks like a
|
@bosmanx sorry about this! we'll get it fixed up and cut another release as soon as we can. |
Related: #2828 |
Hey @bosmanx , terribly sorry for the trouble here. I sent a patch in #2959 to address this, and right now I'm trying to duplicate the setup you described to confirm things work as expected. If you have the chance and ability to build Terraform from that branch, it would be awesome to help me confirm this is fixed. If not, I should know with some confidence soon. Again, I sincerely apologize for this. We're working on patching and then cutting a new release today. |
We weren't marking skipped nodes as failing, so any grandchild-and-deeper dependencies would still evaluate. For example: A -> B -> C -> D If B failed, C would be skipped, but D would still be evaluated. This fixes the behavior so C, D, and any further descendents will all be skipped when B fails. Addresses crashing aspect of #2955 and likely a lot of other confusing failure modes.
We weren't marking skipped nodes as failing, so any grandchild-and-deeper dependencies would still evaluate. For example: A -> B -> C -> D If B failed, C would be skipped, but D would still be evaluated. This fixes the behavior so C, D, and any further descendents will all be skipped when B fails. Addresses crashing aspect of #2955 and likely a lot of other confusing failure modes.
@catsby verified that this works for me, thanks for putting together this PR so quickly. Do you think it would be possible to release a patched version after this is merged? I'd really like to take advantage of some of the changes in |
@jszwedko we're waiting on one more hot fix but yes, a new release should go out ASAP with this |
Awesome, thank you @catsby ! |
Also, apologies for not responding to #2828 before 0.6.2 was cut. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Hi,
Looks like problem is with my tfstate - http://pastebin.com/BTaXQMxC
The text was updated successfully, but these errors were encountered: