core: don't check any parts of a computed set in InstanceDiff.Same #7205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for "same" values in a computed hash, not only might some of the values differ between versions changing the hash, but there may be fields not included at all in the original map, and different overall counts. Instead of trying to match individual set fields with different hashes, remove any hashed key longer than the computed key with the same base name.
| parts := strings.Split(k, ".") | ||
| parts2 := strings.Split(k, ".") | ||
| parts2 := append([]string(nil), parts...) |
There was a problem hiding this comment.
The append with []string(nil) base is a new one on me - looks like it makes sure parts2 is a freshly allocated slice?
There was a problem hiding this comment.
yup! equivalent to parts2 := make([]string, len(parts)); copy(parts2, parts)
|
After chatting on phone about detail - this LGTM! |
This was referenced Jun 20, 2016
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for "same" values in a computed hash, not only might some
of the values differ between versions changing the hash, but there may be
fields not included at all in the original map, and different overall
counts.
Instead of trying to match individual set fields with different hashes,
remove any hashed key longer than the computed key with the same base
name.
Fixes #2027 (and hopefully a number of other "diffs didn't match during apply" issues)