Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: don't check any parts of a computed set in InstanceDiff.Same #7205

Merged
merged 3 commits into from
Jun 17, 2016
Merged

core: don't check any parts of a computed set in InstanceDiff.Same #7205

merged 3 commits into from
Jun 17, 2016

Commits on Jun 16, 2016

  1. Don't check any parts of a computed hash in Same 

    When checking for "same" values in a computed hash, not only might some
of the values differ between versions changing the hash, but there may be
fields not included at all in the original map, and different overall
counts.

Instead of trying to match individual set fields with different hashes,
remove any hashed key longer than the computed key with the same base
name.
    @jbardin
    jbardin committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    a5c1bf1 View commit details
    Browse the repository at this point in the history

  2. Add a failing acceptance test from GH-2027

    @jbardin
    jbardin committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    a3e2c99 View commit details
    Browse the repository at this point in the history

  3. Add a core test for InstanceDiff.Same

    @jbardin
    jbardin committed Jun 16, 2016
    Configuration menu
    Copy the full SHA
    f4ef16a View commit details
    Browse the repository at this point in the history