Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add aws_eip data source #9833

Merged
merged 6 commits into from
Dec 13, 2016
Merged

Conversation

rhoegg
Copy link
Contributor

@rhoegg rhoegg commented Nov 3, 2016

This allows users to look up the allocation ID of an Elastic IP given the public IP, or vice versa.


if id := d.Get("id"); id != "" {
req.AllocationIds = []*string{aws.String(id.(string))}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we only do the lookup if given the id, is that correct? I don't see where we attempt to read the public_ip and query AWS on that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, and my acceptance test passed. Looking at it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think commit 5490cc8 took care of this, and made sure the acceptance test would catch it as well.

@apparentlymart apparentlymart changed the title aws/provider: Add aws_eip data source provider/aws: Add aws_eip data source Nov 3, 2016
@stack72
Copy link
Contributor

stack72 commented Dec 13, 2016

Hi @rhoegg

Thanks for making the suggested changes! This LGTM now :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccDataSourceAwsEip'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/13 12:06:42 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccDataSourceAwsEip -timeout 120m
=== RUN   TestAccDataSourceAwsEip
--- PASS: TestAccDataSourceAwsEip (19.15s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	19.171s

Paul

@stack72 stack72 merged commit 7321379 into hashicorp:master Dec 13, 2016
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants