-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add aws_eip data source #9833
Conversation
|
||
if id := d.Get("id"); id != "" { | ||
req.AllocationIds = []*string{aws.String(id.(string))} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we only do the lookup if given the id
, is that correct? I don't see where we attempt to read the public_ip
and query AWS on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, and my acceptance test passed. Looking at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think commit 5490cc8 took care of this, and made sure the acceptance test would catch it as well.
Hi @rhoegg Thanks for making the suggested changes! This LGTM now :)
Paul |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This allows users to look up the allocation ID of an Elastic IP given the public IP, or vice versa.