Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Addition of suspended_processes to aws_autoscaling_group #10096

Merged
merged 1 commit into from
Nov 21, 2016
Merged

provider/aws: Addition of suspended_processes to aws_autoscaling_group #10096

merged 1 commit into from
Nov 21, 2016
+198 −0

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 14, 2016 •
edited
Loading

Fixes #8954

Addition of the support of autoScaling group suspended_processes

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAutoScalingGroup_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/14 09:26:46 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAutoScalingGroup_ -timeout 120m
=== RUN   TestAccAWSAutoScalingGroup_importBasic
--- PASS: TestAccAWSAutoScalingGroup_importBasic (168.81s)
=== RUN   TestAccAWSAutoScalingGroup_basic
--- PASS: TestAccAWSAutoScalingGroup_basic (249.96s)
=== RUN   TestAccAWSAutoScalingGroup_autoGeneratedName
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (45.19s)
=== RUN   TestAccAWSAutoScalingGroup_terminationPolicies
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (76.54s)
=== RUN   TestAccAWSAutoScalingGroup_tags
--- PASS: TestAccAWSAutoScalingGroup_tags (335.68s)
=== RUN   TestAccAWSAutoScalingGroup_VpcUpdates
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (109.83s)
=== RUN   TestAccAWSAutoScalingGroup_WithLoadBalancer
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (581.32s)
=== RUN   TestAccAWSAutoScalingGroup_withPlacementGroup
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (143.59s)
=== RUN   TestAccAWSAutoScalingGroup_enablingMetrics
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (204.27s)
=== RUN   TestAccAWSAutoScalingGroup_suspendingProcesses
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (250.06s)
=== RUN   TestAccAWSAutoScalingGroup_withMetrics
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (44.23s)
=== RUN   TestAccAWSAutoScalingGroup_ALB_TargetGroups
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (181.99s)
=== RUN   TestAccAWSAutoScalingGroup_initialLifecycleHook
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (322.36s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	2713.870s

@stack72 stack72 mentioned this pull request Nov 14, 2016
Closed
@stack72 stack72 changed the title [WIP] provider/aws: Addition of suspended_processes to aws_autoscaling_group provider/aws: Addition of suspended_processes to aws_autoscaling_group Nov 14, 2016
catsby
catsby suggested changes Nov 18, 2016
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/suggestion

builtin/providers/aws/resource_aws_autoscaling_group.go
@@ -412,6 +426,11 @@ func resourceAwsAutoscalingGroupRead(d *schema.ResourceData, meta interface{}) e
d.Set("health_check_type", g.HealthCheckType)
d.Set("launch_configuration", g.LaunchConfigurationName)
d.Set("load_balancers", flattenStringList(g.LoadBalancerNames))
if g.SuspendedProcesses != nil {
Copy link
Contributor

@catsby catsby Nov 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have suspended processes, and all of them are removed (assuming they can be removed) externally, this guard will prevent us from detecting the drift, correct? If so, then we should remove this guard and just make sure flattenAsgSuspendedProcesses will return an empty list when g.SuspendedProcesses is nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooohhhh good catch! Adding this now

@stack72 stack72 force-pushed the f-aws-asg-suspended_processes branch from 476d0fe to 463071b Compare November 19, 2016 15:44
@stack72
provider/aws: Addition of suspended_processes to aws_autoscaling_group
fcd3e4c 
Fixes #8954

Addition of the support of autoScaling group suspended_processes
@stack72 stack72 force-pushed the f-aws-asg-suspended_processes branch from 463071b to fcd3e4c Compare November 21, 2016 10:14
@stack72
Copy link
Contributor Author

stack72 commented Nov 21, 2016

@catsby made the change as requested :)

catsby
catsby approved these changes Nov 21, 2016
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stack72 stack72 merged commit b3fad6a into master Nov 21, 2016
@stack72 stack72 deleted the f-aws-asg-suspended_processes branch November 21, 2016 15:02
@stack72 stack72 mentioned this pull request Dec 5, 2016
Closed
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
@stack72
provider/aws: Addition of suspended_processes to aws_autoscaling_group (
d55ad75 
hashicorp#10096)

Fixes hashicorp#8954

Addition of the support of autoScaling group suspended_processes
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Feb 27, 2017
@stack72 @fatmcgav
provider/aws: Addition of suspended_processes to aws_autoscaling_group (
1b05634 
hashicorp#10096)

Fixes hashicorp#8954

Addition of the support of autoScaling group suspended_processes
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aws autoscaling group suspended_processes attribute
2 participants
@stack72 @catsby