Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/docker: authentication via values instead of files #10151

Merged
merged 2 commits into from
Nov 22, 2016
Merged

provider/docker: authentication via values instead of files #10151

merged 2 commits into from
Nov 22, 2016

Conversation

mkuzmin
Copy link
Contributor

@mkuzmin mkuzmin commented Nov 15, 2016

This PR adds new parameters for configuring remote Docker host for encryption and client authentication via inline values instead of external files.

provider "docker" {
  host = "tcp://hostname:2376"
  ca_material = "${tls_self_signed_cert.docker_ca.cert_pem}"
  cert_material = "${tls_locally_signed_cert.docker_client.cert_pem}"
  key_material = "${tls_private_key.docker_client.private_key_pem}"
}

This allows referencing other resources, for example from TLS and Vault providers.

See a complete example at https://github.com/mkuzmin/terraform-demo/tree/a851f57feda0e694e6a908baff019d6ea79b0316

@stack72
Copy link
Contributor

stack72 commented Nov 18, 2016

Hi @mkuzmin

Thanks so much for the PR here - so, we have been moving towards doing something like key_material rather than paths to files. I just merged the work for moving the chef provider towards this for 0.8 (#10105)

If possible, could you follow the same pattern here?

Thanks

Paul

@stack72 stack72 added enhancement provider/docker waiting-response An issue/pull request is waiting for a response from the community labels Nov 18, 2016
@mkuzmin
Copy link
Contributor Author

mkuzmin commented Nov 18, 2016

I've renamed all three parameters, and also add handling for environment variables.
Please take a look.

@stack72
Copy link
Contributor

stack72 commented Nov 22, 2016

Looks good to me now :) Thanks for following up so fast on this :)

P.

@stack72 stack72 merged commit c1a9a0c into hashicorp:master Nov 22, 2016
@mkuzmin mkuzmin deleted the docker-auth branch November 22, 2016 16:52
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
…p#10151)

* Docker authentication via values

* Rename parameters to ca_material, cert_material, and key_material. Add environment variables.
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Feb 27, 2017
…p#10151)

* Docker authentication via values

* Rename parameters to ca_material, cert_material, and key_material. Add environment variables.
@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/docker waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants