terraform: destroy resources in dependent providers first #10659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4645 This is something that never worked (even in legacy graphs), but as we push forward towards encouraging multi-provider usage especially with things like the Vault data source, I want to make sure we have this right for 0.8. When you have a config like this: ``` resource "foo_type" "name" {} provider "bar" { attr = "${foo_type.name.value}" } resource "bar_type" "name" {} ``` Then the destruction ordering MUST be: 1. `bar_type` 2. `foo_type` Since configuring the client for `bar_type` requires accessing data from `foo_type`. Prior to this PR, these two would be done in parallel. This properly pushes forward the dependency. There are more cases I want to test but this is a basic case that is fixed.
This extends the prior commit to also verify (and fix) that resources of dependent providers are destroyed first even when they're within modules.
|
Looks like this could also fix #5340, but I'm not 100% sure... |
|
You're right that does look the same! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4645
This is something that never worked (even in legacy graphs), but as we
push forward towards encouraging multi-provider usage especially with
things like the Vault data source, I want to make sure we have this
right for 0.8.
When you have a config like this:
Then the destruction ordering MUST be:
bar_typefoo_typeSince configuring the client for
bar_typerequires accessing data fromfoo_type. Prior to this PR, these two would be done in parallel. Thisproperly pushes forward the dependency.
THIS PR:
There are likely more edge cases but I think I got the most common ones.