provider/statuscake: fix StatusCake tests #10660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the vendored
DreamItGetIT/statuscake
package to its latest version in order to include a fix regarding contact IDs. It also fixes theCreateTest
andUpdateTest
functions, which were not setting all attributes supported bystatuscake_test
resources.The existing bug resulted in having resource states inconsistent with the respective entities in StatusCake. As a way to prevent that in the future I extended the existing tests to include consistency checks for attributes.
This is pretty much my first time writing Go code, so I probably missed some idioms and style considerations. Suggestions for improvements are welcome :)
Fixes #8708.