Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/statuscake: fix StatusCake tests #10660

Merged
merged 2 commits into from
Dec 11, 2016

Conversation

ruippeixotog
Copy link
Contributor

This pull request updates the vendored DreamItGetIT/statuscake package to its latest version in order to include a fix regarding contact IDs. It also fixes the CreateTest and UpdateTest functions, which were not setting all attributes supported by statuscake_test resources.

The existing bug resulted in having resource states inconsistent with the respective entities in StatusCake. As a way to prevent that in the future I extended the existing tests to include consistency checks for attributes.

This is pretty much my first time writing Go code, so I probably missed some idioms and style considerations. Suggestions for improvements are welcome :)

Fixes #8708.

@stack72
Copy link
Contributor

stack72 commented Dec 11, 2016

Thanks so much for the work here @ruippeixotog

This LGTM!

% make testacc TEST=./builtin/providers/statuscake
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/11 19:41:05 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/statuscake -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccStatusCake_basic
--- PASS: TestAccStatusCake_basic (1.60s)
=== RUN   TestAccStatusCake_withUpdate
--- PASS: TestAccStatusCake_withUpdate (3.09s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/statuscake	4.704s

@stack72 stack72 merged commit 5016a56 into hashicorp:master Dec 11, 2016
terraformbot pushed a commit that referenced this pull request Dec 12, 2016
[origin/master] provider/statuscake: fix StatusCake tests (#10660)
5016a56
terraformbot pushed a commit that referenced this pull request Dec 12, 2016
[origin/master] provider/statuscake: fix StatusCake tests (#10660)
5016a56
@ruippeixotog ruippeixotog deleted the fix-statuscake branch January 31, 2017 11:54
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatusCake contact_id does not work
2 participants