removes region param from google_compute_backend_service

[zachgersh]

• this param was not being used in this service
• you need a regional_backend_service if you want to pass this
• docs also updated

[zachgersh]

@stack72 - can I get a review here?This should be a super easy merge.

[stack72]

Hi @zachgersh

Thanks for the work here - sorry it took so long to get back to you on it. So, the usual way we do this is to deprecate the parameter. IF we don't deprecate it, anyone who has set the param in their terraform config will get an error message. I suggest the following change:

"region": {
	Type:       schema.TypeString,
	Optional:   true,
  ForceNew:   true,
	Deprecated: "This parameter has been removed as it was never used",
},

Then for Terraform 0.9, we can completely remove the parameter

Does this make sense?

Thanks

Paul

[zachgersh]

You got it, easy change and I will fire that in shortly. No apologies needed - you all are busy, totally understandable.

…

On Jan 17, 2017, 6:53 AM -0800, Paul Stack ***@***.***>, wrote: Hi @zachgersh (https://github.com/zachgersh) Thanks for the work here - sorry it took so long to get back to you on it. So, the usual way we do this is to deprecate the parameter. IF we don't deprecate it, anyone who has set the param in their terraform config will get an error message. I suggest the following change: "region": { Type: schema.TypeString, Optional: true, ForceNew: true, Deprecated: "This parameter has been removed as it was never used", }, Then for Terraform 0.9, we can completely remove the parameter Does this make sense? Thanks Paul — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (#10903 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAqFA3NOQX4Lnm9t2cqch8it61JE7pawks5rTNXrgaJpZM4LUCw2).

[zachgersh]

@stack72 this should be good to go now - let me know if there is anything else here.

[stack72]

LGTM! Thanks @zachgersh :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.