Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix panic caused by main route table lookup #11152

Merged
merged 1 commit into from
Jan 11, 2017

Conversation

grubernaut
Copy link
Contributor

A VPC's main route table has an implicit subnet association, not an explicit subnet association. This caused a Terraform panic when using the data_source_aws_route_table resource to query the main route table for a VPC.

This fixes the Terraform panic, and allows the data lookup to complete successfully. Also added an acceptance test to verify the bugfix.

Fixes: #11134

A VPC's main route table has an implicit subnet association, not an explicit subnet association. This caused a Terraform panic when using the `data_source_aws_route_table` resource to query the main route table for a VPC.

This fixes the Terraform panic, and allows the data lookup to complete successfully. Also added an acceptance test to verify the bugfix.

Fixes: #11134
@grubernaut grubernaut force-pushed the b-aws-route-table-11134 branch from 727b040 to 7399401 Compare January 11, 2017 17:33
@paddycarver
Copy link
Contributor

LGTM 👍

@grubernaut grubernaut merged commit 3de923d into master Jan 11, 2017
@grubernaut grubernaut deleted the b-aws-route-table-11134 branch January 11, 2017 17:51
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_route_table crash on terraform plan
2 participants