Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StatusCake test timeout schema #11541

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

ruippeixotog
Copy link
Contributor

Although timeout in StatusCake tests is defined correctly in the documentation as an optional value, in the resource it is defined as a computed value - most probably a copy-paste error.

The default value of 40 is the one shown in the StatusCake Web UI when a test is created manually.

@stack72
Copy link
Contributor

stack72 commented Jan 31, 2017

Thanks for this :) This LGTM!

% make testacc TEST=./builtin/providers/statuscake                                                                                        ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/31 12:43:25 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/statuscake -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccStatusCake_basic
--- PASS: TestAccStatusCake_basic (2.20s)
=== RUN   TestAccStatusCake_withUpdate
--- PASS: TestAccStatusCake_withUpdate (4.37s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/statuscake	6.586s

@stack72 stack72 merged commit c6619b3 into hashicorp:master Jan 31, 2017
stack72 pushed a commit that referenced this pull request Jan 31, 2017
@ruippeixotog ruippeixotog deleted the fix-statuscake-timeout branch January 31, 2017 12:53
arcadiatea pushed a commit to ticketmaster/terraform that referenced this pull request Feb 9, 2017
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants