Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: update DNS names in tests. #11794

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

paddycarver
Copy link
Contributor

@paddycarver paddycarver commented Feb 8, 2017

Our DNS tests were using terraform.test as a DNS name, which GCP was
erroring on, as we haven't proven we own the domain (and can't, as we
don't). To solve this, I updated the tests to use hashicorptest.com,
which we do own, and which we have proven ownership of. The tests now
pass.

Test output after changes:

=== RUN   TestAccDnsManagedZone_basic
--- PASS: TestAccDnsManagedZone_basic (3.51s)
=== RUN   TestAccDnsRecordSet_basic
--- PASS: TestAccDnsRecordSet_basic (25.45s)
=== RUN   TestAccDnsRecordSet_modify
--- PASS: TestAccDnsRecordSet_modify (159.13s)
=== RUN   TestAccDnsRecordSet_changeType
--- PASS: TestAccDnsRecordSet_changeType (36.80s)
PASS

Test output before changes:

=== RUN TestAccDnsRecordSet_basic
 --- FAIL: TestAccDnsRecordSet_basic (0.41s) testing.go:265: Step 0 error: Error applying: 1 error(s) occurred: * google_dns_managed_zone.parent-zone: Error creating DNS ManagedZone: googleapi: Error 400: Please verify ownership of the 'terraform.test.' domain (or a parent) at http://www.google.com/webmasters/verification/ and try again, verifyManagedZoneDnsNameOwnership FAIL

Our DNS tests were using terraform.test as a DNS name, which GCP was
erroring on, as we haven't proven we own the domain (and can't, as we
don't). To solve this, I updated the tests to use hashicorptest.com,
which we _do_ own, and which we have proven ownership of. The tests now
pass.
@stack72
Copy link
Contributor

stack72 commented Feb 8, 2017

LGTM!

@paddycarver paddycarver merged commit f8fdd6e into master Feb 8, 2017
@grubernaut grubernaut deleted the paddy_fix_gcp_dns_tests branch May 11, 2017 00:31
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants