provider/aws: Fix SecurityGroupRule regression

[grubernaut]

A security_group_rule can also be created from a prefix_list_id.
Introduced in #11809

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSecurityGroupRule_PrefixListEgress'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/10 12:41:40 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSecurityGroupRule_PrefixListEgress -timeout 120m
=== RUN   TestAccAWSSecurityGroupRule_PrefixListEgress
--- PASS: TestAccAWSSecurityGroupRule_PrefixListEgress (33.94s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    33.970s

Full test output:

##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_ExpectInvalidTypeError']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_ExpectInvalidTypeError' out='=== RUN   TestAccAWSSecurityGroupRule_ExpectInvalidTypeError|n--- PASS: TestAccAWSSecurityGroupRule_ExpectInvalidTypeError (0.02s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_ExpectInvalidTypeError' out='']
##teamcity[testFinished timestamp='2017-02-10T13:13:20.344' name='TestAccAWSSecurityGroupRule_ExpectInvalidTypeError']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.241' name='TestAccAWSSecurityGroupRule_Issue5310']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_Issue5310' out='=== RUN   TestAccAWSSecurityGroupRule_Issue5310|n--- PASS: TestAccAWSSecurityGroupRule_Issue5310 (14.24s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_Issue5310' out='']
##teamcity[testFinished timestamp='2017-02-10T13:13:34.574' name='TestAccAWSSecurityGroupRule_Issue5310']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_Ingress_Classic']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_Ingress_Classic' out='=== RUN   TestAccAWSSecurityGroupRule_Ingress_Classic|n--- PASS: TestAccAWSSecurityGroupRule_Ingress_Classic (14.28s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_Ingress_Classic' out='']
##teamcity[testFinished timestamp='2017-02-10T13:13:34.602' name='TestAccAWSSecurityGroupRule_Ingress_Classic']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_Egress']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_Egress' out='=== RUN   TestAccAWSSecurityGroupRule_Egress|n--- PASS: TestAccAWSSecurityGroupRule_Egress (18.69s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_Egress' out='']
##teamcity[testFinished timestamp='2017-02-10T13:13:39.029' name='TestAccAWSSecurityGroupRule_Egress']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_Ingress_VPC']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_Ingress_VPC' out='=== RUN   TestAccAWSSecurityGroupRule_Ingress_VPC|n--- PASS: TestAccAWSSecurityGroupRule_Ingress_VPC (18.78s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_Ingress_VPC' out='']
##teamcity[testFinished timestamp='2017-02-10T13:13:39.101' name='TestAccAWSSecurityGroupRule_Ingress_VPC']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_MultiIngress']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_MultiIngress' out='=== RUN   TestAccAWSSecurityGroupRule_MultiIngress|n--- PASS: TestAccAWSSecurityGroupRule_MultiIngress (29.15s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_MultiIngress' out='']
##teamcity[testFinished timestamp='2017-02-10T13:13:49.486' name='TestAccAWSSecurityGroupRule_MultiIngress']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_SelfReference']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_SelfReference' out='=== RUN   TestAccAWSSecurityGroupRule_SelfReference|n--- PASS: TestAccAWSSecurityGroupRule_SelfReference (47.06s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_SelfReference' out='']
##teamcity[testFinished timestamp='2017-02-10T13:14:07.387' name='TestAccAWSSecurityGroupRule_SelfReference']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_SelfSource']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_SelfSource' out='=== RUN   TestAccAWSSecurityGroupRule_SelfSource|n--- PASS: TestAccAWSSecurityGroupRule_SelfSource (51.90s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_SelfSource' out='']
##teamcity[testFinished timestamp='2017-02-10T13:14:12.224' name='TestAccAWSSecurityGroupRule_SelfSource']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.241' name='TestAccAWSSecurityGroupRule_PartialMatching_basic']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_PartialMatching_basic' out='=== RUN   TestAccAWSSecurityGroupRule_PartialMatching_basic|n--- PASS: TestAccAWSSecurityGroupRule_PartialMatching_basic (53.34s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_PartialMatching_basic' out='']
##teamcity[testFinished timestamp='2017-02-10T13:14:13.682' name='TestAccAWSSecurityGroupRule_PartialMatching_basic']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_Ingress_Protocol']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_Ingress_Protocol' out='=== RUN   TestAccAWSSecurityGroupRule_Ingress_Protocol|n--- PASS: TestAccAWSSecurityGroupRule_Ingress_Protocol (55.43s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_Ingress_Protocol' out='']
##teamcity[testFinished timestamp='2017-02-10T13:14:15.768' name='TestAccAWSSecurityGroupRule_Ingress_Protocol']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.241' name='TestAccAWSSecurityGroupRule_PrefixListEgress']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_PrefixListEgress' out='=== RUN   TestAccAWSSecurityGroupRule_PrefixListEgress|n--- PASS: TestAccAWSSecurityGroupRule_PrefixListEgress (56.25s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_PrefixListEgress' out='']
##teamcity[testFinished timestamp='2017-02-10T13:14:16.581' name='TestAccAWSSecurityGroupRule_PrefixListEgress']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_PartialMatching_Source']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_PartialMatching_Source' out='=== RUN   TestAccAWSSecurityGroupRule_PartialMatching_Source|n--- PASS: TestAccAWSSecurityGroupRule_PartialMatching_Source (59.66s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_PartialMatching_Source' out='']
##teamcity[testFinished timestamp='2017-02-10T13:14:20.005' name='TestAccAWSSecurityGroupRule_PartialMatching_Source']
##teamcity[testStarted timestamp='2017-02-10T13:13:20.240' name='TestAccAWSSecurityGroupRule_Race']
##teamcity[testStdOut name='TestAccAWSSecurityGroupRule_Race' out='=== RUN   TestAccAWSSecurityGroupRule_Race|n--- PASS: TestAccAWSSecurityGroupRule_Race (319.31s)|nPASS|n']
##teamcity[testStdErr name='TestAccAWSSecurityGroupRule_Race' out='']
##teamcity[testFinished timestamp='2017-02-10T13:18:39.638' name='TestAccAWSSecurityGroupRule_Race']

[stack72]

Nice work @grubernaut / @catsby

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.