Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show message if state lock acquisition/release is slow #11944

Merged
merged 6 commits into from
Feb 14, 2017
Merged

Conversation

mitchellh
Copy link
Contributor

This is just a UX change, but please check for any behavior modifications.

This shows a message if a state lock/unlock is taking longer than a threshold set currently at 400ms. This is a period of time where we want to let the user know we're doing something. Most state lock/unlock is very quick so we don't want to pollute the output with messages all the time. This will only show when its slow.

Example:

Slow Lock

This also adds more verbose error messaging is unlocking fails:

2017-02-14 at 11 40 am

@mitchellh mitchellh requested a review from jbardin February 14, 2017 19:40
@mitchellh mitchellh added this to the Terraform 0.9 milestone Feb 14, 2017
@mitchellh mitchellh merged commit 235b7eb into master Feb 14, 2017
@mitchellh mitchellh deleted the f-state-slow branch February 14, 2017 22:00
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants