Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates heroku-go to the latest revision #12575

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

alindeman
Copy link
Contributor

After many years of being broken, schematic and heroku-go can generate the Heroku API again 🎉

But the generated code looks a bit different now and also requires passing a context.Context as the first argument.

This PR does not introduce any functionality, but does update the library to the latest revision. It will, however, open the door to implementing long-requested functionality like pipelines and spaces.

@alindeman
Copy link
Contributor Author

=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccHerokuAddon_Basic
--- PASS: TestAccHerokuAddon_Basic (2.60s)
=== RUN   TestAccHerokuAddon_noPlan
--- PASS: TestAccHerokuAddon_noPlan (3.29s)
=== RUN   TestAccHerokuApp_Basic
--- PASS: TestAccHerokuApp_Basic (1.51s)
=== RUN   TestAccHerokuApp_NameChange
--- PASS: TestAccHerokuApp_NameChange (2.91s)
=== RUN   TestAccHerokuApp_NukeVars
--- PASS: TestAccHerokuApp_NukeVars (2.62s)
=== RUN   TestAccHerokuApp_Organization
--- SKIP: TestAccHerokuApp_Organization (0.00s)
        resource_heroku_app_test.go:121: HEROKU_ORGANIZATION is not set; skipping test.
=== RUN   TestAccHerokuCert_Basic
--- PASS: TestAccHerokuCert_Basic (9.81s)
=== RUN   TestAccHerokuDomain_Basic
--- PASS: TestAccHerokuDomain_Basic (1.99s)
=== RUN   TestAccHerokuDrain_Basic
--- PASS: TestAccHerokuDrain_Basic (1.97s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/heroku 26.716s

@stack72
Copy link
Contributor

stack72 commented Mar 10, 2017

This is fantastic news - thanks so much for this @alindeman :) LGTM!

@stack72 stack72 merged commit fa18174 into hashicorp:master Mar 10, 2017
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
vanstee pushed a commit to vanstee/terraform that referenced this pull request Sep 28, 2017
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants