ignore_changes causes keys in other flatmapped objects to be lost from diff #12897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore_changes is causing changes in other flatmapped sets to be filtered out incorrectly. This required fixing the testDiffFn to create diffs which include the old value, breaking one other test.
jbardin
force-pushed
the
jbardin/ignore-changes
branch
from
0cec6fe to
f71fc1c
Compare
mitchellh
approved these changes
Mar 21, 2017
When transforming a diff from DestroyCreate to a simple Update, ignore_changes can cause keys from flatmapped objects to be filtered form the diff. We need to filter each flatmapped container as a whole to ensure that unchanged keys aren't lost in the update.
jbardin
force-pushed
the
jbardin/ignore-changes
branch
from
f71fc1c to
0ae0076
Compare
|
Just fixed up some comments with that last rebase. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transforming a diff from DestroyCreate to a simple update cause be
ignore_changes, we need to filter each flatmapped container as a whole
to ensure that unchanged keys aren't lost in the update.
Previously, unchanged fields in a list, set or map were being filtered out of the diff because they looked like empty, but because they are updated as a whole these fields would then be removed from the instance.
Fixes #9043