Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix crash when computed nested map given in module block #13343

Merged
merged 2 commits into from
Apr 4, 2017
Merged

core: fix crash when computed nested map given in module block #13343

merged 2 commits into from
Apr 4, 2017
+86 −5

Commits on Apr 4, 2017

  1. core: fix crash when computed nested map given in module block 

    This crash resulted because the type switch checked for either of two
types but the type assertion within it assumed only one of them.

A straightforward (if inelegant) fix is to simply duplicate the relevant
case block and change the type assertion, thus allowing the types to match
up in all cases.

This fixes #13297.
    @apparentlymart
    apparentlymart committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    a34f75f View commit details
    Browse the repository at this point in the history

  2. core: basic test of EvalVariableBlock 

    This previously lacked tests altogether. This new test verifies the
"happy path", ensuring that both literal and computed values pass through
correctly into the VariableValues map.
    @apparentlymart
    apparentlymart committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    df4c0a0 View commit details
    Browse the repository at this point in the history