Refactoring of bitbucket provider with better error support and general improvments

[cwood]

Also doesnt use decode/encode anymore since those methods are more
intended for streams. So this goes to the more standed marshal/unmarshal
of data.

This also adds better error support and will try to give the user
better errors from the api if it can. Or any issues with the bitbucket
service.

[cwood]

I have run the acceptence test and they work. Before the tests were failing on EOF cause of using decode.

=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccBitbucketDefaultReviewers_basic
--- PASS: TestAccBitbucketDefaultReviewers_basic (4.37s)
=== RUN   TestAccBitbucketHook_basic
--- PASS: TestAccBitbucketHook_basic (5.60s)
=== RUN   TestAccBitbucketRepository_basic
--- PASS: TestAccBitbucketRepository_basic (2.79s)
PASS
ok      github.com/cwood/terraform/builtin/providers/bitbucket  12.778s

[apparentlymart]

Hi @cwood!

Just to make sure I understand what we have here... does this address the question raised on StackOverflow, either by making that error go away or by returning a more helpful error? I think I remember you saying that it was an authentication error causing that failure, so perhaps this change just makes Terraform return a more specific error message in that situation?

[cwood]

This solves that issue by having better error messages. Most of their issues were fine even when authenticated. From what I remember using decode/encode is meant for streams of data so it can be a issue with it.

[apparentlymart]

This all looks good to me!

I don't know the BitBucket API at all, so I'm just trusting that you know what you're doing there 😀 but overall this approach looks good to me and I'm excited for better error messages.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.