provider/aws: Fix EMR Bootstrap Action Ordering

[catsby]

aws_emr_cluster has a bootstrap_actions parameter, which itself has an args parameter. args is stored as a TypeSet, which does not preserve ordering of it's items. See #10691.

In this PR we change the args from TypeSet to TypeList.

This is considered a Breaking Change.. kind of (BC)

Users who upgrade to this version will experience a diff on their next plan run, however, this is deemed necessary because of the lack of ordering that's currently in place. Essentially, users have specified the order, but Terraform is not honoring that, and the API may have a different order. Changing this is required, and it can't be migrated because the change will need to happen on the API side as well.

• e3e6f90 Adds TestAccAWSEMRCluster_bootstrap_ordering, a failing test for EMR Bootstrap Actions, demonstrating the problem
• 6c9b832 (cherry-picked from aws_emr_cluster: Fix bootstrap action parameter ordering #11049)
• 8e63a0a which reads the bootstrap actions back to state

Fixes #10691

---

The failing test, before the fix:

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEMRCluster_bootstrap_ordering -timeout 120m
=== RUN   TestAccAWSEMRCluster_bootstrap_ordering
--- FAIL: TestAccAWSEMRCluster_bootstrap_ordering (645.01s)
        testing.go:280: Step 0 error: Check failed: Check 2/2 error: Error matching Bootstrap args:
                        expected: []string{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"}
                        got: []string{"7", "3", "1", "5", "9", "10", "4", "8", "2", "6"}
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    645.039s

After the fix(es):

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEMRCluster_bootstrap_ordering -timeout 120m
=== RUN   TestAccAWSEMRCluster_bootstrap_ordering
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (603.95s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    603.970s

[apparentlymart]

LGTM, though I would defer to someone who knows this resource better than I do if such a person is available. 😀

[grubernaut]

LGTM

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.