Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add tagging support to the 'aws_lambda_function' resource #13873

Merged
merged 1 commit into from
Apr 23, 2017
Merged

provider/aws: Add tagging support to the 'aws_lambda_function' resource #13873

merged 1 commit into from
Apr 23, 2017

Conversation

ewbankkit
Copy link
Contributor

Add support for tagging to the aws_lambda_function resource.

I split what would normally be a single file tagsLambda.go into two, tagsLambda.go for lambda-specific tag routines and tagsGeneric.go for what seems like more generic map[string]*string tag routines.

Acceptance test:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLambdaFunction_tags'

Bonus acceptance test for Python 3.6 support:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLambdaFunction_runtimeValidation_python36'

@stack72
Copy link
Contributor

stack72 commented Apr 23, 2017

Hi @ewbankkit

This LGTM! Love the addition of a tagsGeneric func - this will be able to be used in other locations

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLambdaFunction_tags' 
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/23 04:44:57 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLambdaFunction_tags -timeout 120m
=== RUN   TestAccAWSLambdaFunction_tags
--- PASS: TestAccAWSLambdaFunction_tags (133.41s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	133.435s

Thanks for the work here as usual :)

Paul

@stack72 stack72 merged commit ff9af4c into hashicorp:master Apr 23, 2017
@ewbankkit ewbankkit deleted the aws_lambda_function-tags branch April 29, 2017 20:10
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants