-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/digitalocean: Add image data source to sidebar #14030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions, otherwise LGTM :)
@@ -11,6 +11,15 @@ | |||
</li> | |||
|
|||
<li<%= sidebar_current("docs-do-resource") %>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this is a data source - I think this should be docs-do-datasource
?
@@ -11,6 +11,15 @@ | |||
</li> | |||
|
|||
<li<%= sidebar_current("docs-do-resource") %>> | |||
<a href="#">Data Sources</a> | |||
<ul class="nav nav-visible"> | |||
<li<%= sidebar_current("docs-do-resource-image") %>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this is a data source, should this be docs-do-datasource-image
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good point, will fix that
003309a
to
a50591d
Compare
@tombuildsstuff fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Ref #13787