provider/aws: Add EMR Security Configuration Resource #14080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubernaut
approved these changes
Apr 28, 2017
|
|
||
| d.Set("creation_date", resp.CreationDateTime) | ||
| d.Set("configuration", resp.SecurityConfiguration) | ||
|
|
There was a problem hiding this comment.
Need to set name here for the import case, more than likely
|
|
||
| * `name` - (Optional) A unique name for this Security Configuration | ||
| * `name_prefix` - (Optional) A prefix for the name of this Security Configuration. | ||
| Terraform will generate a unique suffix.E.g: `tf-emr-sc-1234` |
There was a problem hiding this comment.
Maybe clarify that this is only when both name and name_prefix are unset
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validateJsonString, |
There was a problem hiding this comment.
Should we normalize the JSON string to prevent diffs?
There was a problem hiding this comment.
Sadly it seems that adding the normal StateFunc for this actually causes some diffs
catsby
force-pushed
the
f-aws-emr-security-configs
branch
from
5e8f9e7
to
075c7b7
Compare
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
emr_security_configurationresource for Terraform to manage.This is a companion PR to #13620 and implements #11830
It does not cover ListConfigurations; that should probably be a data source