Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/heroku: Fix heroku_cert update of ssl cert #14240

Merged
merged 9 commits into from
May 10, 2017
Merged

provider/heroku: Fix heroku_cert update of ssl cert #14240

merged 9 commits into from
May 10, 2017

Commits on May 6, 2017

  1. Attempt to write a new test for cert update 

    Trying to surface this bug with a test:
hashicorp#5930
    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    3fa2dff View commit details
    Browse the repository at this point in the history

  2. Fix the error

    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    cf0b03c View commit details
    Browse the repository at this point in the history

  3. Fix the test for the update operation

    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    5e34eb9 View commit details
    Browse the repository at this point in the history

  4. Break apart tests for EU vs US to cleanse test run

    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    28178b9 View commit details
    Browse the repository at this point in the history

  5. Refactor Update to more closely match create, increase debug logging

    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    5c779d2 View commit details
    Browse the repository at this point in the history

  6. Reflect differences of EU and US regions via separate tests

    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    8e91b6c View commit details
    Browse the repository at this point in the history

  7. Add comment re: why of test breakout

    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    da375cd View commit details
    Browse the repository at this point in the history

  8. Removed the “SetId” as it was unnecessary

    @wchrisjohnson
    wchrisjohnson committed May 6, 2017
    Configuration menu
    Copy the full SHA
    00d0061 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2017

  1. Ensure the SSL Addon has been provisioned

    @wchrisjohnson
    wchrisjohnson committed May 10, 2017
    Configuration menu
    Copy the full SHA
    3c05047 View commit details
    Browse the repository at this point in the history