Allow import of Route 53 records with underscores in the name

[brycekahle]

Fixes #12637, fixes #14465
Supersedes #14466

[akumria]

Personally I would not have done the extra checking to ensure the R53 supported resource records (as, if it changes, it requires a new terraform build).

But lgtm.

[brycekahle]

@akumria That is the only way to know if the last part is a set name, which requires popping off another section to get the record type.

[handlerbot]

@brycekahle Thank you for coding this up! I'm getting tripped up on this on the regular right now. 😱

I fear this may have stalled out due to the Terraform/provider split that happened very recently, do you have the time to port your change over to the new GitHub org & repo for the AWS provider, and re-issue this PR there, in the new home of the code? https://github.com/terraform-providers/terraform-provider-aws

[handlerbot]

(If not, I'm glad to try and shuffle this along to success in any way you find acceptable, just let me know!)

[stack72]

Hi @brycekahle / @handlerbot

I am taking care of this PR right now

Thanks

Paul

[cazorla19]

Well, is it closed? Can you provide a link to the issue in terraform-provider-aws?
I still don't see a PR there although this bugfix is definitely important.

[handlerbot]

@cazorla19 hashicorp/terraform-provider-aws@2556b00

Can confirm this works, I used it shortly after it was committed.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.