provider/github Add repository deploy key resource to provider github #15215
Conversation
| Title: &t, | ||
| } | ||
|
|
||
| if readOnly, ok := d.GetOk("read_only"); ok { |
There was a problem hiding this comment.
We have a default value - therefore, there is no need for the d.GetOk("") here - it will always be there
We can replace this and do it inline in the &github.Key like Key and Title
| return err | ||
| } | ||
|
|
||
| d.Set("key", *key.Key) |
There was a problem hiding this comment.
Let's not dereference these - d.Set takes care of this safely
| * `repository` - (Required) Name of the Github repository. | ||
| * `title` - (Required) A title. | ||
|
|
||
| Changing any of the fields forces re-creating the resource. |
There was a problem hiding this comment.
Please can you add the import section to the bottom of the docs
There was a problem hiding this comment.
@stack72 Thanks a ton!
stack72
added
enhancement
provider/github
waiting-response
|
@stack72 Thanks for your very quick response! I addressed all three points pointed out above. Please have a look again. |
|
@stack72 As far as I can see this PR has not been migrated to https://github.com/terraform-providers/terraform-provider-github by the hashibot. Will this stay part of this repo or do I have to re-submit to https://github.com/terraform-providers/terraform-provider-github? |
|
Hi @jtsaito I can take care of migrating this now that you have fixed it up as expected Thanks for the work here Paul |
|
Hi @jtsaito I just used the git patch to push this to the other repo - thanks for the work here :) Paul |
|
@stack72 Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This is PR adds a repository deploy key resource to the github provider.
This is an a slightly updated version of the WIP PR: #13576.