Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recursive targeting on modules #15293

Conversation

josephholsten
Copy link
Contributor

@josephholsten josephholsten commented Jun 14, 2017

Rebase of #9236

@apparentlymart
Copy link
Contributor

Note to self, for later review in more detail: this patch changes the ResourceAddress population so that when no resource type is present Type is set to the magic string "module". Subsequent changes since this PR was originally submitted have added a HasResourceSpec method to ResourceAddress that would be broken by merging this, since it expects a resource-only address to have an empty Type.

@josephholsten
Copy link
Contributor Author

also note: the original PR contained modification to terraform/transform_resource.go but the modern terraform/transform_resource_count.go uses a completely different implementation. I have no idea if that could break anything.

@dcosson
Copy link
Contributor

dcosson commented Jul 19, 2017

Any chance of getting this reviewed/merged? From #9236 it sounded like this was blocked on being able to merge breaking changes for 0.10, and since there are now 2 betas out for 0.10 I'm guessing we've reached that point?

@apparentlymart
Copy link
Contributor

Ahh, I had independently rebased and tweaked this in #15314, which went out in 0.10.0-beta1. Sorry I didn't catch this one while I was working on that.

@dcosson
Copy link
Contributor

dcosson commented Jul 19, 2017

Oh awesome! Thanks for getting this through

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants