Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Azurerm example ci updates #15310

Merged
merged 130 commits into from
Jun 16, 2017

Conversation

anniehedgpeth
Copy link
Contributor

Build Status

This branch tested all of 16 AzureRM examples, and all passed (excluding OpenShift which is not included on the CI).

This PR is to incorporate a few minor changes into the scripts used for validation of the AzureRM Terraform examples. These changes are all limited to the CI build scripts of the Azure examples and do not affect functionality of the templates in any way. These changes only affect the functionality which builds and cleans up the resources for validation in the CI process.

This PR includes:

  • version pinning of azuresdk/azure-cli-python:0.2.10
  • changing environment variables consumed by the Travis CI used in our fork of Terraform
  • changed the default storage account type of a CI dependent resource in a variables file
  • adding a command to delete disks on the azure-vm-from-user-image example
  • adding a command to manually delete resource group on azure-vm-custom-image-new-storage-account

And I added one miscellaneous edit which adds a graph to the README of azure-cdn-with-storage-account.

anniehedgpeth and others added 30 commits April 17, 2017 19:07
…t script, added mac specific deployment for local testing
* initial commit - 101-vm-from-user-image
* added tfvars and info for README
* added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing
* prep for PR
@stack72
Copy link
Contributor

stack72 commented Jun 16, 2017

Thanks for the work here as ever @anniehedgpeth :)

@stack72 stack72 merged commit 14a2c04 into hashicorp:master Jun 16, 2017
@anniehedgpeth
Copy link
Contributor Author

Thanks, again, @stack72 !

@anniehedgpeth anniehedgpeth deleted the azurerm-example-ci-updates branch June 16, 2017 14:00
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants