helper/schema: Add Set.HashEqual #15819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equality of schema.Sets gets tricky when dealing with nested sets - Set.Equal only superficially compares the underlying maps and hence any sets nested under the root sets cause issues. This adds a simple method, HashEqual, that does a top-level hash comparison, helping to work around this without any complex re-invention of things like reflect.DeepEqual. Of course, in order to make effective use of this function, the user needs to make sure they are properly hashing their nested sets, however this is trivial with things like HashResource.
Just to make sure equality on outer and inner values does not affect anything.
vancluever
added a commit
to hashicorp/terraform-provider-vsphere
that referenced
this pull request
Aug 16, 2017
Note that this will break until hashicorp/terraform#15819 gets in as many of the tests depend on Set.HashEqual to test the equality of complex nested sets.
apparentlymart
approved these changes
Aug 16, 2017
|
Thanks for the review @apparentlymart! 👍 |
vancluever
added a commit
to hashicorp/terraform-provider-vsphere
that referenced
this pull request
Aug 18, 2017
Note that this will break until hashicorp/terraform#15819 gets in as many of the tests depend on Set.HashEqual to test the equality of complex nested sets.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equality of
schema.Setsgets tricky when dealing with nested sets -Set.Equalonly superficially compares the underlying maps and hence anysets nested under the root sets cause issues.
This adds a simple method,
HashEqual, that does a top-level hashcomparison, helping to work around this without any complex re-invention
of things like
reflect.DeepEqual.Of course, in order to make effective use of this function, the user
needs to make sure they are properly hashing their nested sets, however
this is trivial with things like
HashResource.