-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait until salt-masterless commands are finished #16704
Conversation
example terraform resource definition with digital ocean |
Hello, any news? We currently cannot use our extensive salt masterless configuration with Terraform due to #16678, and this PR should fix it :-) |
@apparentlymart current masterless provisioning is not working. what do we need to do get this merged to master. |
#16142 is partial fix. this pull request waits for all calls to complete. |
I can validate this pull request fixes the issue on GCP. I will be testing it as well shortly on AWS and will update once I have verified it there as well. JFYI. |
Hi @subbarao! Sorry for the delay here. Things get a bit hectic around release time so we're a bit behind. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
current implementation doesn't wait until the salt download, install, apply commands are finished.
So current version is not working due to this. also piped output from this command to stdout.