Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait until salt-masterless commands are finished #16704

Merged
merged 2 commits into from
Dec 5, 2017

Conversation

subbarao
Copy link
Contributor

current implementation doesn't wait until the salt download, install, apply commands are finished.
So current version is not working due to this. also piped output from this command to stdout.

@subbarao
Copy link
Contributor Author

screen shot 2017-11-19 at 4 01 37 pm

@subbarao
Copy link
Contributor Author

subbarao commented Nov 19, 2017

example terraform resource definition with digital ocean
https://gist.github.com/subbarao/a226b4671f235690a3b1444b9749cbc4

@marco-m
Copy link
Contributor

marco-m commented Nov 26, 2017

Hello, any news? We currently cannot use our extensive salt masterless configuration with Terraform due to #16678, and this PR should fix it :-)

@subbarao
Copy link
Contributor Author

@apparentlymart current masterless provisioning is not working. what do we need to do get this merged to master.

@subbarao
Copy link
Contributor Author

#16142 is partial fix. this pull request waits for all calls to complete.

@gapotts
Copy link

gapotts commented Dec 5, 2017

I can validate this pull request fixes the issue on GCP. I will be testing it as well shortly on AWS and will update once I have verified it there as well. JFYI.

@apparentlymart
Copy link
Contributor

Hi @subbarao! Sorry for the delay here. Things get a bit hectic around release time so we're a bit behind.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants