Fully enable shutdown for plan and refresh in the local backend #16833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an addendum to #16816, which enabled the cancellation in the commands, but expected the backend cancellation to work. |
Cancellation in the local backend was only implemented for apply.
The mock provider couldn't be stopped during diff, because the single mutex was held through the oepration. Release the mutex so Stop can be called.
Now that the local backend can be cancelled during plan and refresh, we don't really need the testShutdownHook. Simplify the tests by just checking for Stop being called on the provider.
jbardin
force-pushed
the
jbardin/plan-shutdown
branch
from
bc8440e to
2941ed4
Compare
apparentlymart
approved these changes
Dec 5, 2017
|
I agree. Trying to DRY those though will take some work on better abstractions, singe all three operations operate on slightly different types, with slightly different UI output, and different checks after. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backends need to specifically watch for and handle context cancellation because the context received for the operation is disjoint from the context used in the RunningOperation. This was only implemented in the apply operation, so the other operations couldn't be fully cancelled.