Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "build_auth_token" option to Habitat Provisioner #16903

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Adds "build_auth_token" option to Habitat Provisioner #16903

merged 1 commit into from
Dec 14, 2017

Conversation

rwc
Copy link
Contributor

@rwc rwc commented Dec 13, 2017

Context: Per @bixu's comment (#16280 (comment)) on the original Habitat Provisioner PR, @nsdavidson and I moved forward with adding the ability to use private Habitat origins that require HAB_AUTH_TOKEN.

This PR:

  • Adds the build_auth_token option in terraform and necessary functionality through which a user's HAB_AUTH_TOKEN can be passed.
  • Updates the docs

First successful run with private origin and HAB_AUTH_TOKEN set

Update struct, schema, and decodeConfig names to more sensible versions

Cleaned up formatting

Update habitat provisioner docs

Remove unused unitstring
@rwc rwc changed the title Adds build_auth_token option to Habitat Provisioner Adds "build_auth_token" option to Habitat Provisioner Dec 13, 2017
@nsdavidson
Copy link
Contributor

nsdavidson commented Dec 13, 2017

I have built this locally and verified that it works as expected. As mentioned, this was requested on original Habitat provisioner PR, and will be a must have for folks using private origins on the build service (https://bldr.habitat.sh).

Thanks @rwcee!

@jbardin
Copy link
Member

jbardin commented Dec 14, 2017

Thanks @rwcee and @nsdavidson!

@jbardin jbardin merged commit 03ddb91 into hashicorp:master Dec 14, 2017
@bixu
Copy link

bixu commented Dec 14, 2017

@jbardin, how can we track that this has been released in an official Terraform build?

@jbardin
Copy link
Member

jbardin commented Dec 14, 2017

Hi @bixu,

With few exceptions, public releases are from the master branch, so the next tag and release will contain these changes. We don't have a set schedule, but it tends to be around a 2 week cycle, give or take depending on the changes made (which means we're about due for a release).

@rwc rwc deleted the build-service-auth-token branch December 21, 2017 02:39
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants