Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump AWS provider to support cn-northwest-1 state #17216

Merged
merged 2 commits into from
Feb 6, 2018
Merged

deps: Bump AWS provider to support cn-northwest-1 state #17216

merged 2 commits into from
Feb 6, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 27, 2018 

# Commit with cn-northwest-1 support
govendor fetch github.com/terraform-providers/terraform-provider-aws/...@bf7787d6cf97cf76a262fa31bae521dc45065d2b
# To fix build errors and for good measure
govendor fetch github.com/aws/aws-sdk-go/...@v1.12.67
# No errors
make test

This was referenced Jan 29, 2018
Merged
Closed
catsby
catsby approved these changes Feb 5, 2018
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

FWIW AWS is at v1.12.70 as of right now, so if you wanted to re-do this for that version and ping me we can merge it before it gets stale 😄

@bflad
Copy link
Contributor Author

bflad commented Feb 6, 2018

@catsby updated:

govendor fetch github.com/terraform-providers/terraform-provider-aws/...@v1.8.0
govendor fetch github.com/aws/aws-sdk-go/...@v1.12.70
make test
# no errors locally

@bflad bflad merged commit ec25a32 into master Feb 6, 2018
@bflad bflad deleted the f-aws-cn-northwest-1 branch February 6, 2018 23:01
bflad added a commit that referenced this pull request Feb 13, 2018
@bflad
Update CHANGELOG for #17216
7475ce6
smartb-pair pushed a commit to smartb-pair/terraform that referenced this pull request Feb 16, 2018
@bflad
Update CHANGELOG for hashicorp#17216
068f50e
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apparentlymart apparentlymart apparentlymart approved these changes

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
backend/s3 dependencies Auto-pinning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @apparentlymart @catsby