Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up remote.Cmd api #17609

Merged
merged 2 commits into from
Mar 23, 2018
Merged

clean up remote.Cmd api #17609

merged 2 commits into from
Mar 23, 2018

Commits on Mar 16, 2018

  1. clean up remote.Cmd api

    Combine the ExitStatus and Err values from remote.Cmd into an error
    returned by Wait, better matching the behavior of the os/exec package.
    
    Non-zero exit codes are returned from Wait as a remote.ExitError.
    Communicator related errors are returned directly.
    
    Clean up all the error handling in the provisioners using a
    communicator. Also remove the extra copyOutput synchronization that was
    copied from package to package.
    jbardin committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    3fbdee0 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2018

  1. have remote.ExitError format errors and status

    Since all use cases of ExitStatus are just putting it into fmt.Errorf,
    usually with the command string, have ExitStatus do that for the caller.
    jbardin committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    ad8642e View commit details
    Browse the repository at this point in the history