Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/azurerm: support for authenticating via SAS Tokens #19440

Merged
merged 5 commits into from
Nov 22, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This PR adds support for authenticating using a SAS Token, which allows limited access permissions to be used to access a Storage Account.

Needs to be merged after #19433

Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Feel free to leave the defer stuff as is, if you prefer.

@tombuildsstuff
Copy link
Contributor Author

Ignoring the known failing tests (which are fixed by #19441) - the tests otherwise look good:

screenshot 2018-11-22 at 17 43 30

@tombuildsstuff tombuildsstuff merged commit 96b1c95 into master Nov 22, 2018
@tombuildsstuff tombuildsstuff deleted the f/backend/azurerm-sas-auth branch November 22, 2018 17:02
tombuildsstuff added a commit that referenced this pull request Nov 22, 2018
@ps23
Copy link

ps23 commented Feb 1, 2019

Is possible to get a working example for that in .tf style?

terraform {
  backend "azurerm" {
    sas_token            = "xxx"
  }
}

Does it aim at the SAS token for the container (az storage container generate-sas ...) or the blob (az storage blob generate-sas ...) itself?

@abelal83
Copy link

I see this PR was merged before tf v0.11.11 was built but sas_token doesn't seem to be supported?

@tombuildsstuff
Copy link
Contributor Author

@abelal83 unfortunately this PR is not included in v0.11.11 - it will ship as a part of Terraform 0.12

@ps23
Copy link

ps23 commented Feb 18, 2019

@abelal83 unfortunately this PR is not included in v0.11.11 - it will ship as a part of Terraform 0.12

Is it in the current alpha?

@abelal83
Copy link

That's great to hear @tombuildsstuff

@abelal83
Copy link

@ps23 don't think it is. I had a look at the build artifacts and sas key support didn't make it in.

@tombuildsstuff
Copy link
Contributor Author

@ps23 it appears this shipped in Terraform 0.12 Alpha 3 (and later): https://github.com/hashicorp/terraform/blob/master/CHANGELOG.md#0120-alpha3-december-6-2018

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants