Resolve build errors #20576
Resolve build errors #20576
Conversation
changed: err := os.MkdirAll(dir, os.ModePerm) added: defer os.RemoveAll(dir) defer testChdir(t, dir)()
Changed lines 173 and 178 with wrong type of %q to %v
Changed line 235 with wrong type of %q to %v
|
|
There was a problem hiding this comment.
Hi @BradAF , thank you for submitting this and sorry for the long silence.
The changes to the Makefile look good, but there have been conflicting changes to the other files in question since you submitted this. If you can revert those changes (leaving only the updated Makefile) we can review this again. Thanks!
|
I am going to close this due to lack of response, but feel free to open a new PR if you want to resubmit in the future! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
These commits attempt to resolve multiple build failures when attempting to run make and make dev with go version go1.12 linux/amd64 on 4.18.0-1011-azure #11~18.04.1-Ubuntu server.
Build errors:
<script src="https://gist.github.com/BradAF/e9dea1e5ddd0143e7ba620d7070211b2.js"></script>