vendor: go get github.com/hashicorp/go-msgpack@v0.5.4 #21082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By upgrading this to a version that supports Go Modules, we can avoid the redundant dependencies labix.org/v2/mgo and launchpad.net/gocheck. These dependencies come via hashicorp/consul, which we have vendored for the Consul backend. There are no changes to the go-msgpack code here; we're just adopting a newer version that has a go.mod present so that its dependencies can be determined more accurately.
mildwonkey
approved these changes
Apr 24, 2019
bltavares
added a commit
to bltavares/terraform-provider-github
that referenced
this pull request
Apr 24, 2019
Uses hashicorp/terraform#21082 which fixes compilation issues when downloading dependencies
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By upgrading this to a version that supports Go Modules, we can avoid the redundant dependencies
labix.org/v2/mgoandlaunchpad.net/gocheck.These dependencies come via
hashicorp/consul, which we have vendored for the Consul backend.There are no changes to the go-msgpack code here; we're just adopting a newer version that has a go.mod present so that its dependencies can be determined more accurately.
This is an immediate-term fix for #21080. If we later add a new dependency that is either directly served from a Bazaar repository or depends on something that is then the requirement for a working
bzrwill return; permanently avoidingbzris not a goal here, but to the extent that we don't currently have any reason to need these dependencies, this allows us hopefully to avoid this problem long enough for the Bazaar team to fix whatever is making the Bazaar git plugin be broken on Windows systems when working with launchpad. (Since Bazaar is itself developed on Launchpad, I assume they will themselves encounter this problem at some point.)