Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: github.com/aws/aws-sdk-go@v1.20.19 #22055

Closed
wants to merge 1 commit into from

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 12, 2019

Notable changes:

* backend/s3: Support for assuming role using credential process from the shared AWS configuration file

Updated via:

go get github.com/aws/aws-sdk-go@v1.20.19
go mod tidy
go mod vendor

Output from acceptance testing:

--- PASS: TestBackend_impl (0.00s)
--- PASS: TestBackendConfig (0.37s)
--- PASS: TestBackendConfig_invalidKey (0.00s)
--- PASS: TestBackend (3.06s)
--- PASS: TestBackendLocked (9.75s)
--- PASS: TestBackendPrefixInWorkspace (2.16s)
--- PASS: TestKeyEnv (8.06s)
--- PASS: TestRemoteClient_impl (0.00s)
--- PASS: TestRemoteClient (1.87s)
--- PASS: TestRemoteClientLocks (9.29s)
--- PASS: TestForceUnlock (6.86s)
--- PASS: TestRemoteClient_clientMD5 (11.61s)
--- PASS: TestRemoteClient_stateChecksum (12.57s)

Notable changes:

```
* backend/s3: Support for assuming role using credential process from the shared AWS configuration file
```

Output from acceptance testing:

```
--- PASS: TestBackend_impl (0.00s)
--- PASS: TestBackendConfig (0.37s)
--- PASS: TestBackendConfig_invalidKey (0.00s)
--- PASS: TestBackend (3.06s)
--- PASS: TestBackendLocked (9.75s)
--- PASS: TestBackendPrefixInWorkspace (2.16s)
--- PASS: TestKeyEnv (8.06s)
--- PASS: TestRemoteClient_impl (0.00s)
--- PASS: TestRemoteClient (1.87s)
--- PASS: TestRemoteClientLocks (9.29s)
--- PASS: TestForceUnlock (6.86s)
--- PASS: TestRemoteClient_clientMD5 (11.61s)
--- PASS: TestRemoteClient_stateChecksum (12.57s)
```
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

It's not really clear to me from that changelog entry exactly what this achieves since I'm not familiar with the terminology used, but that's probably just because I'm not in AWS land much these days. If there's an AWS documentation page we could link to in the changelog for more context on this feature then that'd be awesome, though!

@ajayk
Copy link
Contributor

ajayk commented Jul 12, 2019

@bflad @apparentlymart there was already PR covering this #21908 ,

@bflad
Copy link
Contributor Author

bflad commented Jul 12, 2019

Hi @ajayk 👋 Sorry I had only scanned the open pull requests by title. I will merge your updated PR instead of this one.

@apparentlymart good call, I was just borrowing the wording from the AWS Go SDK CHANGELOG. I'm not sure if there is an exact documentation page other than https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html but looking at the code I believe the enhancement is supporting a configuration profile that specifies both credential_process and role_arn to work correctly now.

@bflad bflad closed this Jul 12, 2019
@bflad bflad deleted the v-aws-sdk-go-v1.20.19 branch July 12, 2019 17:40
@ajayk
Copy link
Contributor

ajayk commented Jul 12, 2019

@bflad no worries :-) , Thanks for merging

@ghost
Copy link

ghost commented Aug 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants