vendor: Downgrade Azure dependencies #22532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow Terraform providers to upgrade to at least one more minor version of the plugin SDK without major UX hiccups. This concludes (unsuccessful) experiments involving upgrades to SDK with Azure/go-autorest#455 Even with that patch all providers still experience broken UX as described in #22490 This downgrade reduces the uncomfort to only a handful of providers from >100s. The affected providers more or less directly depend on Azure SDK(s), which is ~8. Affected providers practically cannot consume Terraform Plugin SDK with this patch (downgraded Azure SDKs) and can just wait for extracted Terraform Plugin SDK which is planned to be released soon. This reverts the following PRs: - #22247 - #22248 - #22524 - #22525 and it is otherwise result of the following commands ``` go get github.com/Azure/azure-sdk-for-go@v21.3.0 go get github.com/hashicorp/go-azure-helpers@166dfd221bb2 go mod tidy ```
appilon
approved these changes
Aug 20, 2019
tombuildsstuff
approved these changes
Aug 20, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow Terraform providers to upgrade to at least one more minor version of the plugin SDK without major UX hiccups.
This concludes (unsuccessful) experiments involving upgrades to SDK with Azure/go-autorest#455
Even with that patch all providers still experience broken UX as described in #22490
The most likely cause is that all providers already track the old version of Azure SDK in their
go.sum, which is being resolved and compared to the one brought via Terraform Plugin SDK upgrade and that results in ambiguous imports.This downgrade reduces the uncomfort to only a handful of providers from >100s. The affected providers more or less directly depend on Azure SDK(s), which is less than 10% of official providers.
Affected providers practically cannot consume Terraform Plugin SDK with this patch (downgraded Azure SDKs) and will instead wait for extracted Terraform Plugin SDK which is planned to be released soon. This SDK won't suffer from this problem anymore because it doesn't depend on Azure at all as backend logic (inc. Azure backend) stays in Terraform core.
This reverts the following PRs:
and it is otherwise result of the following commands
cc @vancluever @tombuildsstuff @tamalsaha
Here is a full report from attempted upgrade of Terraform SDK of 88 providers to this branch:
https://gist.github.com/radeksimko/573e83b3341a395fd970afe3eaa757d0
(practically result of
go get github.com/hashicorp/terraform@vendor-downgrade-azure-sdkcalled in the root of each repo)Sorry for the back and forth - we explored all paths reasonably available and believe this is the best one forward.